feat(list)!: add list navigation methods (first, last, previous, next) #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
joshka
commented
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=====================================
Coverage 94.4% 94.4%
=====================================
Files 62 62
Lines 14941 14991 +50
=====================================
+ Hits 14110 14160 +50
Misses 831 831 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 16, 2024
joshka
added a commit
that referenced
this pull request
Jun 24, 2024
Also cleans up the list example significantly (see also <#1157>) Fixes: <#1159> BREAKING CHANGE: The `List` widget now clamps the selected index to the bounds of the list when navigating with `first`, `last`, `previous`, and `next`, as well as when setting the index directly with `select`. fix: integ test
joshka
force-pushed
the
jm/list-next-prev
branch
from
f5598eb
to
a43e788
Compare
joshka
force-pushed
the
jm/list-next-prev
branch
from
a43e788
to
e7935cf
Compare
joshka
changed the title
|
Rebased on main, added breaking changes docs, updated commit message and PR comment to note breaking change. |
orhun
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up the list example significantly (see also
#1157)
Fixes: #1159
BREAKING CHANGE: The
Listwidget now clamps the selected index to thebounds of the list when navigating with
first,last,previous, andnext, as well as when setting the index directly withselect.