Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add len() to List #24

Merged
merged 1 commit into from
May 7, 2023
Merged

Conversation

orhun
Copy link
Sponsor Member

@orhun orhun commented Feb 12, 2023

Upstream: #609

close #536

Description

I added the methods for List.

A structure with the name "list" can be length-checked in many libraries, so I added the methods in this library too.

Testing guidelines

I added the tests.

Checklist

Thank you in advance.

@mindoodoo mindoodoo added the enhancement New feature or request label Feb 14, 2023
@joshka joshka added the imported from tui Imported from tui-rs PRs / issues label May 5, 2023
@joshka joshka force-pushed the 609/adding_len_method_in_list branch 2 times, most recently from 2e9c26d to fe8bed4 Compare May 7, 2023 05:23
@joshka
Copy link
Member

joshka commented May 7, 2023

Rebased against main. LGTM

@joshka joshka force-pushed the 609/adding_len_method_in_list branch from fe8bed4 to 2a860f6 Compare May 7, 2023 05:28
@joshka
Copy link
Member

joshka commented May 7, 2023

Fixed clippy issues.

@joshka joshka force-pushed the 609/adding_len_method_in_list branch from 2a860f6 to ef96109 Compare May 7, 2023 05:30
@joshka
Copy link
Member

joshka commented May 7, 2023

conventional commit

@joshka joshka changed the title adding pub fn len in List feat(list): add len() to List May 7, 2023
@joshka joshka merged commit ef96109 into main May 7, 2023
7 checks passed
@joshka joshka deleted the 609/adding_len_method_in_list branch May 7, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request imported from tui Imported from tui-rs PRs / issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants