Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(paragraph): added documentation to the "alignment" method #467

Closed
wants to merge 0 commits into from

Conversation

DreadedHippy
Copy link
Contributor

Added documentation to the alignment method of the Paragraph widget.

This is really just 1 commit, the second commit was made because the first wasn't signed

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #467 (85ab3c7) into main (343c6cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files          40       40           
  Lines       11156    11156           
=======================================
  Hits        10041    10041           
  Misses       1115     1115           
Files Changed Coverage Δ
src/widgets/paragraph.rs 99.81% <ø> (ø)

Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix this up rather than creating a new PR, you can rebase and squash the commits:

git rebase -i
change the second "pick" to "fixup" (or just "f"), save and close
git push origin main

src/widgets/paragraph.rs Outdated Show resolved Hide resolved
src/widgets/paragraph.rs Outdated Show resolved Hide resolved
src/widgets/paragraph.rs Outdated Show resolved Hide resolved
@DreadedHippy
Copy link
Contributor Author

I've resolved all suggested changes.

Although the following error kept popping up:


error[E0432]: unresolved import `sys`
  --> C:\Users\user\.cargo\registry\src\index.crates.io-6f17d22bba15001f\termion-2.0.1\src\raw.rs:29:5
   |
29 | use sys::Termios;
   |     ^^^ maybe a missing crate `sys`?
   |
   = help: consider adding `extern crate sys` to use the `sys` crate

I pushed with the '--no-verify' flag

@joshka
Copy link
Member

joshka commented Sep 5, 2023

Apologies - I just accidentally pushed the main branch over your main branch rather than my local copy of your main branch rebased to your main branch (which closes the PR and locks me out of the branch), so this shows as closed. I've merged it out of band to fix things up however).

Thanks for your first contribution to ratatui!

@DreadedHippy
Copy link
Contributor Author

Ayyyyy! 🚀🚀🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants