Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): added documentation for the 'new' method of the 'table' widget #471

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

DreadedHippy
Copy link
Contributor

Added documentation for the new method of the Table widget

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #471 (f8e9a0c) into main (c8ab2d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          40       40           
  Lines       11166    11166           
=======================================
  Hits        10057    10057           
  Misses       1109     1109           
Files Changed Coverage Δ
src/widgets/table.rs 94.82% <ø> (ø)

@DreadedHippy
Copy link
Contributor Author

DreadedHippy commented Sep 5, 2023

Oh, the gramatical error failing the lint CI comes from the commit message and not the diff. Noted

@joshka joshka merged commit 232be80 into ratatui-org:main Sep 5, 2023
30 of 31 checks passed
@joshka
Copy link
Member

joshka commented Sep 5, 2023

Oh, the gramatical error failing the lint CI comes from the commit message and not the diff. Noted

Yeah - the convention is imperative form ("add" instead of "added") as if you're completing the sentence “If applied, this commit will …”
There's a couple of good blog posts that talk more about the rationale for this:

@DreadedHippy
Copy link
Contributor Author

Oh, the gramatical error failing the lint CI comes from the commit message and not the diff. Noted

Yeah - the convention is imperative form ("add" instead of "added") as if you're completing the sentence “If applied, this commit will …” There's a couple of good blog posts that talk more about the rationale for this:

Thank you very much for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants