Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(block)!: remove deprecated title_on_bottom #757

Merged

Conversation

Valentin271
Copy link
Member

Block::title_on_bottom was deprecated in v0.22. Use Block::title and Title::position instead.

References #738

`Block::title_on_bottom` was deprecated in v0.22. Use `Block::title` and `Title::position` instead.
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a quick github search for this to check how common it is before merging?
I find adding AND (NOT org:ratatui-org) AND (NOT is:fork) helpful in narrowing down the code results.

@Valentin271
Copy link
Member Author

@joshka
Copy link
Member

joshka commented Jan 6, 2024

Sure, I found 1 usage. I think it's safe to merge :)

https://github.com/search?q=.title_on_bottom%28%29+AND+%28NOT+org%3Aratatui-org%29+AND+%28NOT+is%3Afork%29+language%3ARust&type=code&l=Rust

Cool
Pinging https://github.com/johnDeSilencio/emojicp @johnDeSilencio to notify of this change which will likely go out in 0.26.0

@joshka joshka merged commit bc274e2 into ratatui-org:main Jan 6, 2024
36 checks passed
@Valentin271 Valentin271 deleted the refactor/remove-title-on-bottom branch January 6, 2024 22:26
Valentin271 added a commit to Valentin271/ratatui that referenced this pull request Jan 6, 2024
`Block::title_on_bottom` was deprecated in v0.22. Use `Block::title` and `Title::position` instead.
Valentin271 added a commit to Valentin271/ratatui that referenced this pull request Jan 6, 2024
`Block::title_on_bottom` was deprecated in v0.22. Use `Block::title` and `Title::position` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants