New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(line): line truncation respects alignment #987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadoTheMiner
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
March 18, 2024 19:27
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=====================================
Coverage 89.4% 89.4%
=====================================
Files 61 61
Lines 15359 15430 +71
=====================================
+ Hits 13731 13799 +68
- Misses 1628 1631 +3 ☔ View full report in Codecov by Sentry. |
TadoTheMiner
changed the title
fix(line): line truncation now respects alignment
Line truncation now respects alignment
Mar 18, 2024
TadoTheMiner
changed the title
Line truncation now respects alignment
fix(line): line truncation now respects alignment
Mar 18, 2024
TadoTheMiner
changed the title
fix(line): line truncation now respects alignment
fix(line): line truncation respects alignment
Mar 19, 2024
orhun
approved these changes
Mar 19, 2024
EdJoPaTo
reviewed
Mar 24, 2024
joshka
requested changes
Mar 30, 2024
joshka
approved these changes
Mar 31, 2024
Merged - thanks for the effort in this PR! |
You're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a
Line
, the line will be truncated:E.g. "Hello World" will be rendered as "Hello", "World", "lo wo" for
left, right, centered lines respectively.
Fixes: #932