Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that paragraph correctly renders styled text #992

Merged
merged 2 commits into from Mar 22, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Mar 21, 2024

Paragraph was ignoring the new style field on Text added in 0.26.0

Fixes: #990

Paragraph was ignoring the new style field on Text added in 0.26.0

Fixes: #990
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.0%. Comparing base (c56f49b) to head (02e404e).

❗ Current head 02e404e differs from pull request most recent head 2810090. Consider uploading reports for the commit 2810090 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #992   +/-   ##
=====================================
  Coverage   92.0%   92.0%           
=====================================
  Files         61      61           
  Lines      15940   15958   +18     
=====================================
+ Hits       14670   14688   +18     
  Misses      1270    1270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/widgets/paragraph.rs Outdated Show resolved Hide resolved
Co-authored-by: EdJoPaTo <rfc-conform-git-commit-email@funny-long-domain-label-everyone-hates-as-it-is-too-long.edjopato.de>
@joshka joshka merged commit f6c4e44 into main Mar 22, 2024
31 checks passed
@joshka joshka deleted the fix-text-block-style branch March 22, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph wrapped in a block can not be styled as expected
3 participants