Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage by supporting new default loop and new Socket API #129

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

clue
Copy link
Member

@clue clue commented Aug 30, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$connector = new \Ratchet\Client\Connector($loop);

// new (using default loop)
$connector = new \Ratchet\Client\Connector();

ReactPHP now implements the logic that previously lived inside the connect() function itself. This means that although this removes a bunch of code, this should not affect BC at all.

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/socket#260, reactphp/socket#264 and #124

@mbonneau mbonneau merged commit d32c497 into ratchetphp:master Nov 4, 2021
@cboden cboden added this to the 0.4 milestone Nov 4, 2021
@clue clue deleted the default-loop branch October 18, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants