You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The auto_firmware_version.py script is not safe way to establish the version. The script presumes that git describe --tags will work, but that requires that the git repository actually have tags. Without it you get:
fatal: No names found, cannot describe anything.
And the firmware version embedded into the source is empty. This matters because anyone who forks the repository will not carry over all the tags, each repository have their own tag history.
A better place to pull the version number from would be manifest.json file. This contains the actual version number and is independent of any git tagging.
The text was updated successfully, but these errors were encountered:
dkerr64
added a commit
to dkerr64/homekit-ratgdo
that referenced
this issue
Dec 16, 2023
The
auto_firmware_version.py
script is not safe way to establish the version. The script presumes thatgit describe --tags
will work, but that requires that the git repository actually have tags. Without it you get:And the firmware version embedded into the source is empty. This matters because anyone who forks the repository will not carry over all the tags, each repository have their own tag history.
A better place to pull the version number from would be
manifest.json
file. This contains the actual version number and is independent of any git tagging.The text was updated successfully, but these errors were encountered: