Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_firmware_version.py not safe/reliable #38

Closed
dkerr64 opened this issue Dec 14, 2023 · 0 comments
Closed

auto_firmware_version.py not safe/reliable #38

dkerr64 opened this issue Dec 14, 2023 · 0 comments

Comments

@dkerr64
Copy link
Collaborator

dkerr64 commented Dec 14, 2023

The auto_firmware_version.py script is not safe way to establish the version. The script presumes that git describe --tags will work, but that requires that the git repository actually have tags. Without it you get:

fatal: No names found, cannot describe anything.

And the firmware version embedded into the source is empty. This matters because anyone who forks the repository will not carry over all the tags, each repository have their own tag history.

A better place to pull the version number from would be manifest.json file. This contains the actual version number and is independent of any git tagging.

dkerr64 added a commit to dkerr64/homekit-ratgdo that referenced this issue Dec 16, 2023
dkerr64 added a commit to dkerr64/homekit-ratgdo that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant