Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug ] Import ItemDesc #162

Closed
admkakaroto opened this issue Feb 8, 2018 · 25 comments · Fixed by #327
Closed

[ Bug ] Import ItemDesc #162

admkakaroto opened this issue Feb 8, 2018 · 25 comments · Fixed by #327

Comments

@admkakaroto
Copy link

It is not possible to import the description of items in the iteminfo.lua file, even taking the clean fluxcp here in github and the iteminfo.lua file in the zackdreaver repository, the flux starts reading but does not return any description, sometimes it still matters 1 description or 2 at most, I have already changed the size of the php.ini import_max but it does not resolve.

See: https://imgur.com/HzpRf4q

@SneakyRO
Copy link

Mine is not even doing anything
image

@CyberDevil75
Copy link

Same problem with 10mb of zackdreaver's file
suekec

@SneakyRO
Copy link

SneakyRO commented Apr 7, 2018

Guys, it wasn't a bug. Make sure you also have 777 permission on itemInfo.lua file you uploading / or the folder.

Also, check the format in your itemInfo.lua file, I had to regex replace to fit a older format.

@admkakaroto
Copy link
Author

@SneakyRO I do this on localhost with 777 permission, and it only takes 2 items and ignores the rest.

@CyberDevil75
Copy link

exactly what is the folder where the upload file is inserted?

@admkakaroto
Copy link
Author

desktop...

@SneakyRO
Copy link

@admkakaroto Check if you have the right format

@CyberDevil75 Check ur root folder / fluxcp folder

@admkakaroto
Copy link
Author

what format?

@AnisotropicDefixation
Copy link

I can't get this to work either. It would be nice to have a conversion tool or something.

@cydh
Copy link
Contributor

cydh commented Jun 20, 2018

anyone want to try my script? replace your /module/item/iteminfo.php with this iteminfo.php

@admkakaroto
Copy link
Author

@cydh for me it worked perfectly, it imported very fast, I just need to test if it took all the items, but it was sensational.

@admkakaroto
Copy link
Author

however items that have special characters in the description did not work properly on the import.

@admkakaroto
Copy link
Author

items that have special characters are not having their description imported completely.

@cydh
Copy link
Contributor

cydh commented Jun 20, 2018

however items that have special characters in the description did not work properly on the import.

@admkakaroto what is the example? maybe related to the column collation

@AnisotropicDefixation
Copy link

AnisotropicDefixation commented Jun 21, 2018

Works but it seems like a portion of the text is cut, the first line or two and in some cases it's cropped on both ends. Does it require some specific syntax?

@cydh
Copy link
Contributor

cydh commented Jun 21, 2018

uh my bad. wrong cutting string. please retry https://gist.github.com/cydh/f22fcb1920e8c8251c1e1b6614a35811

image

if got anymore cuts, copy here the item block in ur iteminfo (without reformat or post a link) because there's no native lua for PHP and we need to match the patterns/structures in iteminfo

@admkakaroto
Copy link
Author

@cydh
img_itemdesc

@AnisotropicDefixation
Copy link

Seems to work so far, although some descriptions do get botched, maybe due to connection timeouts (would be ideal to have a tool to create a populated SQL table locally). There's an issue with coloring though, anything after ^000000 will change to black and this breaks many descriptions (your own example has this issue also).

@cydh
Copy link
Contributor

cydh commented Jun 22, 2018

well because ^000000 means to black. see what I meant here

I can change with a title workaround, such open with <font color="#000000"> or maybe if every ^000000 as <font class='item-desc-default-color-class'>
we can't rely all desc with ^RRGGBB asdasd ^000000, because it's not pair tag at first place, and you can find more in newer desc

@AnisotropicDefixation
Copy link

AnisotropicDefixation commented Jun 22, 2018

Now that I think about it, it would be nice to have an option to reverse the black text to white, for those who use dark backgrounds so it's readable.

Basically a define option for the "default color" and what comes after ^000000.

@cydh
Copy link
Contributor

cydh commented Jun 22, 2018

updated https://gist.github.com/cydh/f22fcb1920e8c8251c1e1b6614a35811
no more force black

@AnisotropicDefixation
Copy link

AnisotropicDefixation commented Jun 23, 2018

This is nice. I found more issues though;

  1. text [x]^000000", results in nothing getting parsed right after.
  2. %"; results in lack of line break when there should be one.

@admkakaroto
Copy link
Author

still does not work with special characters like '~'` ^' and letters like 'ã õ à è ó ò ú ù'.

@RagnaWay

This comment was marked as spam.

@ffman22
Copy link

ffman22 commented Aug 18, 2021

for mine doesn't work, I try the last file, and it doesn't do anything. after I select the iteminfo.lua and press submit.

another question where can I setup the permission 777 permission on itemInfo.lua
https://drive.goog
fluxcp_error
le.com/file/d/1wg_dX8XCFStmknDSF6Q6CGYQrYK5Svdd/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

8 participants