Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crit item buffs applying on skills when they shouldn't be! #3501

Closed
mrjnumber1 opened this issue Sep 18, 2018 · 0 comments
Closed

Crit item buffs applying on skills when they shouldn't be! #3501

mrjnumber1 opened this issue Sep 18, 2018 · 0 comments
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena

Comments

@mrjnumber1
Copy link

  • rAthena Hash: current
  • Client Date: x
  • Server Mode: pre-renewal (and possibly renewal too)
  • Description of Issue:
    • Result: KVM Bow, The Paper Card, Sharp Arrows, and Drosera card do not match officials!
    • Expected Result: We must match!
    • How to Reproduce: Equip any of the stated items and observe the huge damage boost (or critical boost) when using skills
    • Official Information:
      Pulled from 13.2 zone. Unfortunately, I did not have a chance to check in Renewal, but it probably applies there as well:
  • bonus bCritAtkRate works only for basic attacks (making KVM bow and The Paper Card very strong when Sharpshooting, when they shouldn't be!)
  • bonus bCriticalLong on ammo and cards will behave just as bCritAtkRate - only boosting crit rate for basic attacks, but not for the 3? skills that critical strike.
  • bonus2 bCriticalAddRace works for skills and normal attacks! (this is OK!!! I only listed it to compare because of its oddity!)
  • Modifications that may affect results: x
@aleos89 aleos89 added status:confirmed Issue that has been validated by a developer to affect rAthena component:core A fault that lies within the main framework of rAthena priority:low A fault that affects rAthena in one piece of functionality and is self-contained mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode type:bug Issue that is a bug within rAthena labels Sep 19, 2018
aleos89 added a commit that referenced this issue Sep 19, 2018
@aleos89
Corrected Critical bonuses
9b663c2 
* Fixes #3501.
* Critical bonuses bCritAtkRate and bCriticalLong should not be applying to skills.
Thanks to @mrjnumber1!
@aleos89 aleos89 mentioned this issue Sep 19, 2018
Merged
@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Sep 25, 2018
SeravySensei pushed a commit to SeravySensei/rathena that referenced this issue Jan 26, 2019
@aleos89 @SeravySensei
Corrected Critical bonuses (rathena#3506)
e991d6e 
* Fixes rathena#3501.
* Critical bonuses bCritAtkRate and bCriticalLong should not be applying to skills.
Thanks to @mrjnumber1!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleos89 @mrjnumber1