Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTB card should not block status changes from self skills on self even if they are magic #5918

Closed
Playtester opened this issue May 4, 2021 · 1 comment · Fixed by #6562
Closed
Labels
component:skill A fault that deals specifically with a skill mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena

Comments

@Playtester
Copy link
Member

Playtester commented May 4, 2021

  • Client Date: -
  • Server Mode: Pre-Renewal (but probably applies to both)
  • Description of Issue:

I saw reports that skills like Ruwach and Sight are blocked by GTB since our last change but they shouldn't. Originally I thought we might have incorrectly defined these as "magic", but when testing Magnificat and Gloria on Aegis I noticed that these skills apply status change on self, but are still blocked by GTB on all other targets (so if all in the party wear GTB only caster gets the buff).

Which made me think that maybe for self skills there's a special rule that makes GTB not block status changes. So we actually went and tested all the self-skills that are defined as "magic" in rAthena and all of them applied their status changes to the caster.

Target skills should get blocked even when cast on self.

Self skills should get blocked on all targets except self.

Here's a list of skills that work on self even with GTB on (giving the status change to self but not any other targets with GTB):
Ruwach
Sight
Angelus
Magnificat
Gloria
Energy Coat
Cast Cancel
Magic Rod
Hindsight
Hocus Pocus
Basilica
Mystical Amplification
Indulge
Foresight
Star Gladiator Feel / Comfort Skills
Double Casting
Mirror Image

Note that Grand Cross still doesn't work on self. The whole skill actually fails to cast if you wear GTB.

@Playtester Playtester added type:bug Issue that is a bug within rAthena status:confirmed Issue that has been validated by a developer to affect rAthena labels May 4, 2021
@aleos89 aleos89 added component:skill A fault that deals specifically with a skill mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained labels May 7, 2021
aleos89 added a commit that referenced this issue Jan 26, 2022
* Fixes #5918.
* Target magic skills should get blocked even when cast on self.
* Self magic skills should get blocked on all targets except self.
* Adds an IgnoreGtb skill flag to explicitly allow a skill to bypass these checks.
Thanks to @Playtester!
aleos89 added a commit that referenced this issue Feb 1, 2022
* Fixes #5918.
* Target magic skills should get blocked even when cast on self.
* Self magic skills should get blocked on all targets except self.
* Adds an IgnoreGtb skill flag to explicitly allow a skill to bypass these checks.
Thanks to @Playtester!
@aleos89 aleos89 removed the status:confirmed Issue that has been validated by a developer to affect rAthena label Feb 1, 2022
@jimjimi09
Copy link

Hi, I have tried to add IgnoreGtb: true on Flags on my skill_db.yml unfortunatelly upon @reloadskilldb it doesn't work with GTB. also tried compiling and restarting the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:skill A fault that deals specifically with a skill mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:low A fault that affects rAthena in one piece of functionality and is self-contained type:bug Issue that is a bug within rAthena
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants