Cleaned up map data storage #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Follow up to a942853. * Fixes #3336. * Moved map_data storage to std::map container. * Created map_getmapdata to obtain pointer to map_data. * Got rid of MAX_MAP_PER_SERVER define. * Resolved deletion of instances causing other instances to lose their intended map ID. Thanks to @teededung, @Anacondaqq, and @Lemongrass3110!
aleos89
added
the
status:code-review
* Adjusted some map ID range checks to not check for map size anymore. Thanks to @cydh!
Not one of my best days... -_-"
There might still be more
Lemongrass3110
added
component:core
ghost
mentioned this pull request
|
script function "channel_setcolor" is causing mapserver crash |
This was referenced Aug 8, 2018
SeravySensei
pushed a commit
to SeravySensei/rathena
that referenced
this pull request
Jan 26, 2019
Follow up to a942853. Fixes rathena#3336. Moved map_data storage to std::map container. Created map_getmapdata to obtain pointer to map_data. Got rid of MAX_MAP_PER_SERVER define. Resolved deletion of instances causing other instances to lose their intended map ID. Refactored warp suggestions Thanks to @teededung, @Anacondaqq, @cydh and @Lemongrass3110!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue(s): Server crash after destroying the party #3336
Server Mode: Pre-renewal and Renewal
Description of Pull Request:
Thanks to @teededung, @Anacondaqq, and @Lemongrass3110!