Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Twin Pompom By JB item bonus #4157

Merged
merged 3 commits into from
May 17, 2019
Merged

Corrected Twin Pompom By JB item bonus #4157

merged 3 commits into from
May 17, 2019

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented May 10, 2019

* Fixes #4142.
* Corrected Twin Pompom By JB item bonus to match kRO description.
Thanks to @AzarthMZintos!
@aleos89 aleos89 added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label May 10, 2019
* Piece of Cake should have a 1% drop rate.
* Critical bonus should happen on any type of physical attack.
@aleos89
Copy link
Contributor Author

aleos89 commented May 14, 2019

Now that I look back at the description, anything after the LUK bonus is a Christmas Event bonus. I'll move these bonuses to the import/item_db along with the other event item bonuses.

* The bonus is an event bonus.
@aleos89 aleos89 merged commit 1bd524a into master May 17, 2019
@aleos89 aleos89 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label May 17, 2019
@aleos89 aleos89 deleted the hotfix/issue4142 branch May 17, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants