Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invalid item errors in achievements #4240

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fixed invalid item errors in achievements #4240

merged 1 commit into from
Jul 8, 2019

Conversation

Lemongrass3110
Copy link
Member

  • Addressed Issue(s): Achievement amount reward #4236

  • Server Mode: Both

  • Description of Pull Request:
    The reward amount was getting stored into the wrong field of the achievement structure.

Thanks to @RadianFord

@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena labels Jul 7, 2019
@RadianFord
Copy link
Contributor

Working 100% now. Thank you!

@Lemongrass3110 Lemongrass3110 merged commit 8bb6b11 into master Jul 8, 2019
@Lemongrass3110 Lemongrass3110 deleted the hotfix/issue4236 branch July 8, 2019 06:35
@Lemongrass3110 Lemongrass3110 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleos89 aleos89 aleos89 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lemongrass3110 @RadianFord @aleos89