Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up the item SQL parsing #5478

Merged
merged 5 commits into from Oct 25, 2020
Merged

Cleans up the item SQL parsing #5478

merged 5 commits into from Oct 25, 2020

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Oct 24, 2020

  • Addressed Issue(s): #5477

  • Server Mode: Pre-renewal and Renewal

  • Description of Pull Request:

    • Fixes a couple issues with the column checking.
    • Adds verification to table columns to make sure table format is correct.
    • Cleans up the node processing.
    • Adds a loading progress status.
    • Adjusts the SQL import files to not destroy previously imported data.
    • Updated README.md to reflect the changes for SQL importing.
      Thanks to @Lemongrass3110!

* Fixes a couple issues with the column checking.
* Adds verification to table columns to make sure table format is correct.
* Cleans up the node processing.
* Adds a loading progress status.
* Adjusts the SQL import files to not destroy previously imported data.
* Updated README.md to reflect the changes for SQL importing.
Thanks to @Lemongrass3110!
aleos89 added 2 commits Oct 24, 2020
* Adjusts the node processing checks to look for null only so the import database can disable options.
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Oct 24, 2020

This pull request introduces 1 alert when merging 944db40 into f28019a - view on LGTM.com

new alerts:

  • 1 for Wrong type of arguments to formatting function

@Lemongrass3110 Lemongrass3110 linked an issue Oct 24, 2020 that may be closed by this pull request
@Lemongrass3110 Lemongrass3110 linked an issue Oct 25, 2020 that may be closed by this pull request
@Lemongrass3110 Lemongrass3110 merged commit ad3f48f into master Oct 25, 2020
6 checks passed
@Lemongrass3110 Lemongrass3110 deleted the hotfix/item_sql branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants