Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up the item SQL parsing #5478

Merged
merged 5 commits into from Oct 25, 2020
Merged

Cleans up the item SQL parsing #5478

merged 5 commits into from Oct 25, 2020

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Oct 24, 2020 •
edited by Lemongrass3110

  • Addressed Issue(s): Map Server Crashes #5477

  • Server Mode: Pre-renewal and Renewal

  • Description of Pull Request:

    • Fixes a couple issues with the column checking.
    • Adds verification to table columns to make sure table format is correct.
    • Cleans up the node processing.
    • Adds a loading progress status.
    • Adjusts the SQL import files to not destroy previously imported data.
    • Updated README.md to reflect the changes for SQL importing.
      Thanks to @Lemongrass3110!

@aleos89
Cleans up the item SQL parsing
4bc390b 
* Fixes a couple issues with the column checking.
* Adds verification to table columns to make sure table format is correct.
* Cleans up the node processing.
* Adds a loading progress status.
* Adjusts the SQL import files to not destroy previously imported data.
* Updated README.md to reflect the changes for SQL importing.
Thanks to @Lemongrass3110!
@aleos89 aleos89 added the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Oct 24, 2020
@aleos89
Adjusts CI scripts
0cc81e4
@aleos89
Adjusts node processing checks
944db40 
* Adjusts the node processing checks to look for null only so the import database can disable options.
@lgtm-com
Copy link

lgtm-com bot commented Oct 24, 2020

This pull request introduces 1 alert when merging 944db40 into f28019a - view on LGTM.com

new alerts:

  • 1 for Wrong type of arguments to formatting function

@Lemongrass3110 Lemongrass3110 linked an issue Oct 24, 2020 that may be closed by this pull request
Map Server Crashes #5477
Closed
@Lemongrass3110 Lemongrass3110 mentioned this pull request Oct 25, 2020
Closed
@Lemongrass3110 Lemongrass3110 linked an issue Oct 25, 2020 that may be closed by this pull request
Issue with SQL files. #5485
Closed
@Lemongrass3110 Lemongrass3110 added component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:high A fault that makes rAthena unstable or unusable type:bug Issue that is a bug within rAthena labels Oct 25, 2020
@Lemongrass3110 Lemongrass3110 merged commit ad3f48f into master Oct 25, 2020
@Lemongrass3110 Lemongrass3110 deleted the hotfix/item_sql branch October 25, 2020 23:16
@Lemongrass3110 Lemongrass3110 removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemongrass3110 Lemongrass3110 Lemongrass3110 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode priority:high A fault that makes rAthena unstable or unusable type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with SQL files. Map Server Crashes
2 participants
@aleos89 @Lemongrass3110