Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented some NPC skills #6343

Merged
merged 23 commits into from
Nov 21, 2021
Merged

Implemented some NPC skills #6343

merged 23 commits into from
Nov 21, 2021

Conversation

Atemo
Copy link
Contributor

@Atemo Atemo commented Oct 29, 2021 •
edited

  • Server Mode: renewal
  • Description of Pull Request:

Implemented a bunch of NPC skills (renewal only).
The skills in mob_skill_db are uncommented.

NPC_CHEAL
NPC_MILLENNIUMSHIELD
NPC_STORMGUST2
NPC_ARROWSTORM
NPC_DRAGONBREATH
NPC_WIDEWEB
NPC_REVERBERATION
NPC_COMET
NPC_VENOMIMPRESS
NPC_SR_CURSEDCIRCLE
NPC_DARKPIERCING
NPC_FATALMENACE
NPC_PSYCHIC_WAVE
NPC_DRAGONBREATH
NPC_MAGMA_ERUPTION
NPC_RAYOFGENESIS
NPC_LEX_AETERNA
NPC_MANDRAGORA
NPC_DANCINGBLADE
Uncommented NPC_DARKPIERCING
NPC_PULSESTRIKE2

@Atemo Atemo added component:database A fault that lies within the database of rAthena component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Oct 29, 2021
@Atemo Atemo changed the title Npcskills1 Implemented some NPC skills Oct 29, 2021
attackjom
attackjom reviewed Oct 29, 2021
View reviewed changes
db/re/skill_db.yml Outdated Show resolved Hide resolved
@Takiusu
Copy link
Contributor

Takiusu commented Oct 30, 2021

Finally!

@Michieru
Copy link

Nice job, from what I know there is also some few old NPC skills missing:
id 2539 NPC_ASSASSINCROSS
id 2540 NPC_DISSONANCE
id 2541 NPC_UGLYDANCE
Duno if you plan to add them, they are use for biolab 3 mobs

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2021

This pull request introduces 1 alert when merging 51087c9 into 2910148 - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type

Lemongrass3110
Lemongrass3110 reviewed Nov 16, 2021
View reviewed changes
src/map/battle.cpp Outdated Show resolved Hide resolved
src/map/skill.cpp Outdated Show resolved Hide resolved
Lemongrass3110
Lemongrass3110 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@Lemongrass3110 Lemongrass3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the really small comments I left that are mainly for readability reasons.

@Atemo Atemo merged commit 424e05d into rathena:master Nov 21, 2021
@Atemo Atemo deleted the npcskills1 branch November 21, 2021 17:24
@Atemo Atemo removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label Nov 21, 2021
@Lemongrass3110 Lemongrass3110 mentioned this pull request Jan 16, 2023
Open
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attackjom attackjom attackjom left review comments

@Lemongrass3110 Lemongrass3110 Lemongrass3110 approved these changes

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena component:database A fault that lies within the database of rAthena mode:renewal A fault that exists within the renewal mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Atemo @Takiusu @Michieru @Lemongrass3110 @attackjom