4th / Expanded Job Skill-Updates as of KRO 20220602 incl. 3rd Job fixes / Homunculus skills #7024
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Have you tried to make skill formulas close to the kRo mechanic? |
|
They are mostly exactly what the kRO patch notes / skill descriptions say. With their latest patch many unknown were made clear. I'd need someone on kRO to verify these cases as I don't have access to it. |
|
Ok, thank you for your work! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
* fixes Shadow / Kunai Nightmare fixed cast time * fixes Hack and Slasher Hits / Timing. Recent KRO video suggests it's only 1 attack with 2 hits
This comment was marked as outdated.
This comment was marked as outdated.
* fixes Rush Quake LGTM Warning * fixes Servant Weapon status to only recover one weapon at a time
This comment was marked as outdated.
This comment was marked as outdated.
|
This comment was marked as outdated.
This comment was marked as outdated.
I wanted to keep this PR all about the skills. There are more things to fix about 4th / expanded Jobs, sure. Job level fix got a PR already here: #7029 |
|
SKE_RISING_SUN not need TargetType changed for 'Self' like SKE_RISING_MOON? |
I don't understand. Rising Sun is targeted skill. Rising Moon isn't. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…lupd # Conflicts: # src/map/battle.cpp
Taken from #7024 Co-authored-by: munkrej <schmunk@posteo.de> Co-authored-by: Aleos <aleos89@users.noreply.github.com>
…lupd # Conflicts: # db/re/skill_db.yml # db/re/status.yml # src/map/battle.cpp # src/map/script_constants.hpp # src/map/skill.cpp # src/map/skill.hpp # src/map/status.cpp # src/map/status.hpp
\src\map\script_constants.hppDuplicate skill
|
…lupd # Conflicts: # db/re/skill_db.yml # src/map/battle.cpp
Taken from #7024 Co-authored-by: munkrej <schmunk@posteo.de> Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Taken from #7024 Co-authored-by: munkrej <schmunk@posteo.de>
…lupd # Conflicts: # db/re/skill_db.yml # db/re/status.yml # src/map/battle.cpp # src/map/skill.cpp # src/map/skill.hpp # src/map/status.cpp # src/map/status.hpp
…lupd # Conflicts: # src/map/battle.cpp
|
SH_COLORS_OF_HYUN_ROK skill not change element attack, for example with SU_CN_METEOR. |
Taken from rathena#7024 Co-authored-by: munkrej <schmunk@posteo.de>
Taken from rathena#7024 Co-authored-by: munkrej <schmunk@posteo.de> Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Taken from rathena#7024 Co-authored-by: munkrej <schmunk@posteo.de> Co-authored-by: Atemo <Atemo@users.noreply.github.com>
Taken from rathena#7024 Co-authored-by: munkrej <schmunk@posteo.de>
|
you need to review the battle damage formula. skill . and others, compared to rathena main there is a lot of divergence of information if you need help, I am willing to collaborate. |
|
The content here is very important and makes a big difference, you cannot abandon it like this |
Server Mode: Renewal
Description of Pull Request:
This shall bring all skills to the most recent official state.
4th / Expanded Job Skills, but also some 3rd Jobs skills as well as the 200+ Homunculus skills are included.
This PR's focus is solely on non-NPC skill functionality.
There are many people out there trying to distribute job-skills, but neither are they willing to update / fix them nor try to be accurate with official behaviours. Now there's no guarantee that everything is 100% accurate, but if you have additional official informations I'll gladly update them. Nobody is perfect, right?
As sources I used:
Note: The new skills of Dragon Knight (Dragonic Breath), Biolo (Explosive Powder, Mayhemic Thorns), Meister (Mighty Smash, Spark Blaster, Triple Laser) need a client 20220602+.
New skills showcase
I'm happy to get feedback on the code itself as I'm by no means a rathena/c++-pro and tried to use what was used before or what I thought would be a good solution.
So let's make this great hopefully :)
"Full" changelog
General Code Changes
added new global flags for skill controls:
Skill/Status changes
Homunculus
HAMI_DEFENCE:
added new Skills:
6048:
6049:
6050:
6051:
6052:
Meister
General / SC
summons (ABR_BATTLE_WARIOR, ABR_DUAL_CANNON, ABR_MOTHER_NET):
MT_AXE_STOMP:
MT_RUSH_QUAKE:
MT_M_MACHINE:
MT_A_MACHINE:
MT_D_MACHINE:
MT_SUMMON_ABR_BATTLE_WARIOR:
MT_SUMMON_ABR_DUAL_CANNON:
MT_SUMMON_ABR_MOTHER_NET:
MT_SUMMON_ABR_INFINITY:
NC_BOOSTKNUCKLE:
NC_VULCANARM:
NC_ARMSCANNON:
NC_AXETORNADO:
Biolo
General / SC
Summons:
SUMMON_WOODEN_FAIRY:
GN_CART_TORNADO:
GN_CRAZYWEED_ATK:
BO_BIONIC_PHARMACY:
BO_THE_WHOLE_PROTECTION:
BO_ADVANCE_PROTECTION:
BO_ACIDIFIED_ZONE_WATER:
BO_ACIDIFIED_ZONE_GROUND:
BO_ACIDIFIED_ZONE_WIND:
BO_ACIDIFIED_ZONE_FIRE:
BO_WOODENWARRIOR:
BO_WOODEN_FAIRY:
BO_CREEPER:
BO_RESEARCHREPORT:
BO_HELLTREE:
GN_HELLS_PLANT_ATK:
Troubador/Trouvere
General / SC
TR_RETROSPECTION:
TR_MYSTIC_SYMPHONY:
TR_KVASIR_SONATA:
TR_ROSEBLOSSOM:
TR_ROSEBLOSSOM_ATK:
TR_RHYTHMSHOOTING:
TR_METALIC_FURY:
TR_SOUNDBLEND:
TR_GEF_NOCTURN:
TR_ROKI_CAPRICCIO:
TR_AIN_RHAPSODY:
TR_MUSICAL_INTERLUDE:
TR_JAWAII_SERENADE:
TR_NIPELHEIM_REQUIEM:
TR_PRON_MARCH:
WM_METALICSOUND, WM_REVERBERATION:
Cardinal
General / SC
CD_REPARATIO:
CD_MEDIALE_VOTUM:
CD_ARGUTUS_VITA:
CD_ARGUTUS_TELUM:
CD_ARBITRIUM:
CD_ARBITRIUM_ATK:
CD_PRESENS_ACIES:
CD_EFFLIGO:
CD_COMPETENTIA:
CD_PNEUMATICUS_PROCELLA:
CD_DILECTIO_HEAL:
CD_RELIGIO:
CD_BENEDICTUM:
CD_PETITIO:
CD_FRAMEN:
CD_MEDIALE_VOTUM
Shadow Chaser
SHC_SHADOW_EXCEED:
SHC_DANCING_KNIFE:
SHC_DANCING_KNIFE:
SHC_ETERNAL_SLASH:
SHC_POTENT_VENOM:
SHC_SHADOW_STAB:
SHC_IMPACT_CRATER:
SHC_ENCHANTING_SHADOW:
SHC_FATAL_SHADOW_CROW:
SHC_SAVAGE_IMPACT:
Dragon Knight
General / SC
DK_SERVANTWEAPON:
DK_SERVANTWEAPON_ATK:
DK_SERVANT_W_PHANTOM:
DK_SERVANT_W_DEMOL:
DK_CHARGINGPIERCE:
DK_HACKANDSLASHER:
DK_DRAGONIC_AURA:
DK_MADNESS_CRUSHER:
DK_VIGOR:
DK_STORMSLASH:
RK_WINDCUTTER:
RK_DRAGONBREATH, RK_DRAGONBREATH_WATER:
RK_HUNDREDSPEAR:
Wind Hawk
General / SC
WH_WIND_SIGN:
WH_HAWKRUSH:
WH_CALAMITYGALE:
WH_HAWKBOOMERANG:
WH_GALESTORM:
WH_DEEPBLINDTRAP:
WH_SOLIDTRAP:
WH_SWIFTTRAP:
WH_CRESCIVE_BOLT:
WH_FLAMETRAP:
Elemental Master
General / SC
EM_SPELL_ENCHANTING:
EM_ACTIVITY_BURN:
EM_INCREASING_ACTIVITY:
EM_DIAMOND_STORM:
EM_LIGHTNING_LAND:
EM_VENOM_SWAMP:
EM_CONFLAGRATION:
EM_TERRA_DRIVE:
EM_SUMMON_ELEMENTAL_ARDOR:
EM_SUMMON_ELEMENTAL_DILUVIO:
EM_SUMMON_ELEMENTAL_PROCELLA:
EM_SUMMON_ELEMENTAL_TERREMOTUS:
EM_SUMMON_ELEMENTAL_SERPENS:
EM_ELEMENTAL_BUSTER:
EM_ELEMENTAL_VEIL:
SO_POISON_BUSTER:
SO_VARETYR_SPEAR:
SO_PSYCHIC_WAVE:
Abyss Chaser
General / SC
SC_FATALMENACE:
ABC_STRIP_SHADOW:
ABC_ABYSS_DAGGER:
ABC_UNLUCKY_RUSH:
ABC_CHAIN_REACTION_SHOT:
ABC_FROM_THE_ABYSS:
ABC_ABYSS_SLAYER:
ABC_ABYSS_STRIKE:
ABC_DEFT_STAB:
ABC_ABYSS_SQUARE:
ABC_FRENZY_SHOT:
ABC_CHAIN_REACTION_SHOT_ATK:
ABC_FROM_THE_ABYSS_ATK:
SC_FATALMENACE:
Arch Mage
General / SC
AG_DEADLY_PROJECTION:
AG_DESTRUCTIVE_HURRICANE:
AG_DESTRUCTIVE_HURRICANE_CLIMAX:
AG_RAIN_OF_CRYSTAL:
AG_MYSTERY_ILLUSION:
AG_VIOLENT_QUAKE:
AG_VIOLENT_QUAKE_ATK:
AG_SOUL_VC_STRIKE:
AG_STRANTUM_TREMOR:
AG_ALL_BLOOM:
AG_ALL_BLOOM_ATK:
AG_ALL_BLOOM_ATK2:
AG_CRYSTAL_IMPACT:
AG_CRYSTAL_IMPACT_ATK:
AG_TORNADO_STORM:
AG_FLORAL_FLARE_ROAD:
AG_ASTRAL_STRIKE:
AG_ASTRAL_STRIKE_ATK:
AG_CLIMAX:
AG_ROCK_DOWN:
AG_STORM_CANNON:
AG_CRIMSON_ARROW:
AG_CRIMSON_ARROW_ATK:
AG_FROZEN_SLASH:
Inquisitor
IQ_POWERFUL_FAITH:
IQ_FIRM_FAITH:
IQ_OLEUM_SANCTUM:
IQ_SINCERE_FAITH:
IQ_MASSIVE_F_BLASTER:
IQ_EXPOSION_BLASTER:
IQ_FIRST_BRAND:
IQ_FIRST_FAITH_POWER:
IQ_JUDGE:
IQ_SECOND_FLAME:
IQ_SECOND_FAITH:
IQ_SECOND_JUDGEMENT:
IQ_THIRD_PUNISH:
IQ_THIRD_FLAME_BOMB:
IQ_THIRD_CONSECRATION:
IQ_THIRD_EXOR_FLAME:
Imperial Guard
General / SC
LG_CANNONSPEAR:
LG_BANISHINGPOINT:
LG_SHIELDPRESS:
LG_RAYOFGENESIS:
LG_EARTHDRIVE:
LG_HESPERUSLIT:
LG_OVERBRAND:
IG_GUARD_STANCE:
IG_GUARDIAN_SHIELD:
IG_REBOUND_SHIELD:
IG_ATTACK_STANCE:
IG_ULTIMATE_SACRIFICE:
IG_HOLY_SHIELD:
IG_GRAND_JUDGEMENT:
IG_JUDGEMENT_CROSS:
IG_SHIELD_SHOOTING:
IG_OVERSLASH:
IG_CROSS_RAIN:
LG_MOONSLASHER:
Ninja
General / SC
KO_HAPPOKUNAI:
Soul Reaper
SP_SWHOO:
Star Emperor
General / SC
Rebellion
General / SC
RL_R_TRIP:
Summoner
SU_SCRATCH
SU_LUNATICCARROTBEAT, SU_LUNATICCARROTBEAT2
SU_CN_METEOR:
Other SC
Other Skills
Other General
Produce DB