Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the link for terraform installation #1014

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

yizha1
Copy link
Collaborator

@yizha1 yizha1 commented Aug 22, 2023

Description

What this PR does / why we need it:

The link used for Azure document pointed to a different cloud provider.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1013

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (80122da) 58.17% compared to head (2349d26) 58.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
- Coverage   58.17%   58.16%   -0.02%     
==========================================
  Files          91       91              
  Lines        5447     5448       +1     
==========================================
  Hits         3169     3169              
- Misses       1964     1965       +1     
  Partials      314      314              
Files Changed Coverage Δ
pkg/manager/manager.go 3.35% <0.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal akashsinghal changed the title fix: fix the link for terraform installation docs: fix the link for terraform installation Aug 22, 2023
@susanshi susanshi merged commit 85a5803 into ratify-project:main Aug 23, 2023
14 of 16 checks passed
junczhu pushed a commit to ZAFT-Armored-Keeper-of-Unity/ratify that referenced this pull request Aug 23, 2023
junczhu pushed a commit to ZAFT-Armored-Keeper-of-Unity/ratify that referenced this pull request Aug 23, 2023
junczhu pushed a commit to ZAFT-Armored-Keeper-of-Unity/ratify that referenced this pull request Aug 25, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>

chore: update constraint templates

refactor: refactor log (ratify-project#1008)

fix: display cert store status (ratify-project#1021)

Co-authored-by: Binbin Li <libinbin@microsoft.com>

chore: update constraint templates
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong link used for Azure document
3 participants