-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display cert store status #1021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 58.32% 58.32%
=======================================
Files 92 92
Lines 5529 5529
=======================================
Hits 3225 3225
Misses 1989 1989
Partials 315 315 ☔ View full report in Codecov by Sentry. |
susanshi
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp and
toddysm
as code owners
August 24, 2023 06:12
binbin-li
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thansk for the fix! lgtm
junczhu
pushed a commit
to ZAFT-Armored-Keeper-of-Unity/ratify
that referenced
this pull request
Aug 25, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com> chore: update constraint templates refactor: refactor log (ratify-project#1008) fix: display cert store status (ratify-project#1021) Co-authored-by: Binbin Li <libinbin@microsoft.com> chore: update constraint templates
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
This PR correctly annotates the cert store status properties
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Manual testing with commands below:
Checklist:
Post Merge Requirements
Helm Chart Change