Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update terraform AKV permissions #1024

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

duffney
Copy link
Contributor

@duffney duffney commented Aug 24, 2023

Description

What this PR does / why we need it:

Updates the Terraform configuration to add getSecret permissions to the workload identity that Ratify uses.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #973

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: GitHub <noreply@github.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ff56ec8) 58.32% compared to head (95fa0b6) 58.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files          92       92           
  Lines        5529     5529           
=======================================
  Hits         3225     3225           
  Misses       1989     1989           
  Partials      315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal akashsinghal changed the title Closes issue #973 chore: update terraform AKV permissions Aug 24, 2023
@akashsinghal akashsinghal merged commit d92a173 into ratify-project:main Aug 28, 2023
16 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Terraform sample to use getSecret permissions instead of GetCert
2 participants