Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: retract v1.1.0-alpha.1 #1038

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

binbin-li
Copy link
Collaborator

Description

What this PR does / why we need it:

Retract v1.1.0-alpha.1 correctly following go-cose: https://github.com/veraison/go-cose/pull/153/files.
We need to release a new version that can be pinned to latest, v1.1.0-alpha.2 in this case. And since alpha.1 and alpha.2 are both retracted, then go.pkg would pin rc7 as the latest.
image

The retracted versions of go-cose:
image
image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d92a173) 58.32% compared to head (7f17637) 58.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1038   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files          92       92           
  Lines        5529     5529           
=======================================
  Hits         3225     3225           
  Misses       1989     1989           
  Partials      315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal
Copy link
Collaborator

@binbin-li what would be the process here? do we have to do any formal release?

@binbin-li
Copy link
Collaborator Author

@binbin-li what would be the process here? do we have to do any formal release?

It's not a formal release, we only need to release v1.1.0-alpha.2 to pkg.go.dev which will pin latest to rc.7.

@binbin-li binbin-li merged commit dd468dc into ratify-project:main Aug 29, 2023
16 checks passed
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants