Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: surface plugin error in exec.go #1228

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

susanshi
Copy link
Collaborator

Description

What this PR does / why we need it:

Currently the plugin error from executing the command is not exposed. This PR provides the fix
Fixes #1221 1221

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (49f63e1) 55.15% compared to head (cac50f5) 55.31%.

Files Patch % Lines
pkg/common/plugin/exec.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
+ Coverage   55.15%   55.31%   +0.15%     
==========================================
  Files         104      104              
  Lines        6902     6902              
==========================================
+ Hits         3807     3818      +11     
+ Misses       2760     2749      -11     
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi marked this pull request as ready for review December 18, 2023 23:37
binbin-li
binbin-li previously approved these changes Dec 19, 2023
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

pkg/common/plugin/exec_test.go Outdated Show resolved Hide resolved
pkg/common/plugin/exec.go Show resolved Hide resolved
@susanshi susanshi merged commit be8b182 into ratify-project:main Dec 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve plugin error logs for troubleshooting
2 participants