Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov config #1237

Merged

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Dec 26, 2023

Description

What this PR does / why we need it:

Introduced codecov.yaml for code coverage report configuration
Excluded path ./api
REF:
https://app.codecov.io/gh/deislabs/ratify/pull/1237/tree?search=&displayType=tree
https://docs.codecov.com/docs/ignoring-paths

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@junczhu junczhu marked this pull request as ready for review December 26, 2023 05:38
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (759f299) 55.40% compared to head (51f1159) 61.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   55.40%   61.41%   +6.00%     
==========================================
  Files         105       97       -8     
  Lines        6916     6183     -733     
==========================================
- Hits         3832     3797      -35     
+ Misses       2749     2053     -696     
+ Partials      335      333       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akashsinghal
Copy link
Collaborator

Curious, what's motivation for adding this?

@binbin-li
Copy link
Collaborator

Curious, what's motivation for adding this?

Since api is for CRD generation, and most of them are auto-generated without tests, probably excluding it from test coverage makes sense.

@junczhu junczhu enabled auto-merge (squash) December 30, 2023 04:26
@junczhu junczhu merged commit 2998078 into ratify-project:main Dec 30, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants