Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1022 support plugin logging #1254

Closed

Conversation

duffney
Copy link
Contributor

@duffney duffney commented Jan 8, 2024

Description

What this PR does / why we need it:

Improves the plugin experience by processing additional messages that are sent to stderr and stdout.

plugin-errors

Which issue(s) this PR fixes #1022

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@duffney
Copy link
Contributor Author

duffney commented Jan 9, 2024

NOTE: Ran into an issue when submitting this. Reviewing it now to fix the errors in the build. My git config must have gotten confused between Windows and WSL. :(

@duffney
Copy link
Contributor Author

duffney commented Jan 9, 2024

Closing & reopening PR to fix messed up commits. :)

@duffney duffney closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support logging in External Plugin
1 participant