Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NamespacedKMP and switch KMP scope to cluster [multi-tenancy PR 9] #1422

Merged
merged 20 commits into from
May 2, 2024

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented Apr 29, 2024

Description

What this PR does / why we need it:

This is the 9th PR for multi-tenancy support.

  1. Created new CRD: NamespacedKeyManagementProvider to replace the previous KeyManagementProvider for namespaced KMP resource.
  2. Update the scope from Namespaced to Clustered for the original KeyManagementProvider CRD.
  3. The above 2 changes are intended to ensure uniformity in the naming and scope across all CRDs.
  4. For the cluster controller, it will fetch the Name instead of NamespacedName, which means we'll get ProviderName instead of /ProviderName as an example.
  5. Updated unit tests.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 43.00000% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 66.33%. Comparing base (1bd347c) to head (d06f954).
Report is 1 commits behind head on dev.

Files Patch % Lines
...espaceresource/keymanagementprovider_controller.go 35.21% 46 Missing ⚠️
pkg/manager/manager.go 0.00% 8 Missing ⚠️
...lusterresource/keymanagementprovider_controller.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1422      +/-   ##
==========================================
- Coverage   66.76%   66.33%   -0.44%     
==========================================
  Files         116      118       +2     
  Lines        6030     6107      +77     
==========================================
+ Hits         4026     4051      +25     
- Misses       1620     1672      +52     
  Partials      384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binbin-li binbin-li force-pushed the multi-tenancy-pr-9 branch 2 times, most recently from 05c79e9 to 71b6004 Compare April 29, 2024 04:41
@binbin-li binbin-li changed the title [WIP] feat: add NamespacedKMP and switch KMP scope to cluster [WIP] feat: add NamespacedKMP and switch KMP scope to cluster [multi-tenancy PR 9] Apr 29, 2024
@binbin-li binbin-li changed the title [WIP] feat: add NamespacedKMP and switch KMP scope to cluster [multi-tenancy PR 9] feat: add NamespacedKMP and switch KMP scope to cluster [multi-tenancy PR 9] Apr 29, 2024
@binbin-li binbin-li marked this pull request as ready for review April 29, 2024 14:29
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@susanshi susanshi merged commit 43b8090 into ratify-project:dev May 2, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants