Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete oci artifact tests #928

Merged

Conversation

akashsinghal
Copy link
Collaborator

Description

What this PR does / why we need it:

  • Removes left over OCI Artifact tests

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #927

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • e2e tests pass
  • azure tests pass

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa559b0) 56.08% compared to head (9e3e68f) 56.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   56.08%   56.08%           
=======================================
  Files          87       87           
  Lines        5037     5037           
=======================================
  Hits         2825     2825           
  Misses       1921     1921           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akashsinghal akashsinghal marked this pull request as ready for review July 11, 2023 21:20
@akashsinghal
Copy link
Collaborator Author

Validated on local fork that Azure e2e tests pass

@akashsinghal akashsinghal self-assigned this Jul 11, 2023
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we already have a github issue tracking code any code path related to oci image?

Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@akashsinghal akashsinghal enabled auto-merge (squash) July 12, 2023 17:22
@akashsinghal
Copy link
Collaborator Author

LGTM. Do we already have a github issue tracking code any code path related to oci image?

Good point @susanshi. I'll create a tracking issue. This change will be addressed by the image spec rc 2-> rc4 bump

@akashsinghal akashsinghal mentioned this pull request Jul 12, 2023
1 task
@akashsinghal akashsinghal merged commit 6b73117 into ratify-project:main Jul 12, 2023
13 checks passed
@akashsinghal akashsinghal deleted the akashsinghal/fixOCIAKStest branch July 14, 2023 21:42
junczhu pushed a commit to ZAFT-Armored-Keeper-of-Unity/ratify that referenced this pull request Jul 20, 2023
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure tests failing after notation rc7 bump
3 participants