-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add policy crd and controller #933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
add-policy-crd
branch
2 times, most recently
from
July 17, 2023 12:24
8a905cb
to
e5cb8a8
Compare
binbin-li
force-pushed
the
add-policy-crd
branch
from
July 18, 2023 07:43
e5cb8a8
to
d5ec9bc
Compare
binbin-li
force-pushed
the
add-policy-crd
branch
from
July 18, 2023 08:59
9840a10
to
c4d7901
Compare
binbin-li
force-pushed
the
add-policy-crd
branch
from
July 19, 2023 12:25
c4d7901
to
43cdfa6
Compare
susanshi
reviewed
Jul 19, 2023
susanshi
reviewed
Jul 20, 2023
susanshi
previously approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just left a comment a about small typo, otherwise looks good. thanks!
binbin-li
force-pushed
the
add-policy-crd
branch
3 times, most recently
from
July 20, 2023 08:08
50b5c74
to
f915b7b
Compare
binbin-li
force-pushed
the
add-policy-crd
branch
from
July 20, 2023 08:19
f915b7b
to
8ffc8a9
Compare
susanshi
approved these changes
Jul 21, 2023
bspaans
pushed a commit
to bspaans/ratify
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
PassthroughMode
from featureFlag, add it as a field underRegoPolicyConfig
Use_Rego_Policy
from featureFlag, but add it as a regular chart value.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #936
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Updated e2e tests.
Manual test:
Checklist:
Post Merge Requirements
Helm Chart Change