GroovyEmbeddedApp should implement ratpack.groovy.Groovy.Ratpack

[erdi]

I don't see any reason why it couldn't do so and if it did then you could use the familiar dsl available in Ratpack Groovy scripts when defining embedded applications.

[ldaley]

That's a pretty good idea.

[johnrengelman]

Do we actually mean this class? https://github.com/ratpack/ratpack/blob/master/ratpack-groovy/src/main/java/ratpack/groovy/server/GroovyRatpackServerSpec.java

GroovyEmbeddedApp seems to just be the entry point with the of method.

[johnrengelman]

If so this doesn't appear to be possible as:
https://github.com/ratpack/ratpack/blob/master/ratpack-groovy/src/main/java/ratpack/groovy/Groovy.java#L135

and

https://github.com/ratpack/ratpack/blob/master/ratpack-groovy/src/main/java/ratpack/groovy/server/GroovyRatpackServerSpec.java#L41

clash.

[erdi]

The idea is to be able to use the exact same dsl when defining a groovy
embedded app as the one used in ratpack.groovy.

Why don't we just add another a static method that will take a closure that
delegates to ratpack.groovy.Groovy.Ratpack?

On Monday, 23 May 2016, John Engelman notifications@github.com wrote:

If so this doesn't appear to be possible as:

https://github.com/ratpack/ratpack/blob/master/ratpack-groovy/src/main/java/ratpack/groovy/Groovy.java#L135

and

https://github.com/ratpack/ratpack/blob/master/ratpack-groovy/src/main/java/ratpack/groovy/server/GroovyRatpackServerSpec.java#L41

clash.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#925 (comment)

[johnrengelman]

@erdi - #992