Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at fromJson method in jackson module #288

Merged
merged 4 commits into from
Mar 27, 2014
Merged

Initial attempt at fromJson method in jackson module #288

merged 4 commits into from
Mar 27, 2014

Conversation

craigburke
Copy link
Contributor

Let me know if I'm on the right track here. Once we get it to a point where it looks good I can add documentation as well.

@ldaley
Copy link
Member

ldaley commented Mar 27, 2014

Thanks @craigburke!

This has highlighted a major problem with the Parser class. I'm going to pull this and then make the internal changes needed.

Can you add yourself as a contributor please: https://github.com/ratpack/ratpack/blob/master/ratpack-manual/src/content/chapters/99-about-the-project.md#contributors

I'll pull after that.

@ldaley
Copy link
Member

ldaley commented Mar 27, 2014

I've got some time to work on this today, so I'm going to pull and we can address further work through another pull request.

ldaley added a commit that referenced this pull request Mar 27, 2014
Initial attempt at fromJson method in jackson module
@ldaley ldaley merged commit 6e35d20 into ratpack:master Mar 27, 2014
@craigburke
Copy link
Contributor Author

Sounds good! I'm anxious to see the Parser changes. I'll have some evening time in the next few days so let me know what else I could do for this.

@ldaley ldaley added this to the release-0.9.3 milestone Mar 28, 2014
@ldaley ldaley self-assigned this Mar 28, 2014
@ldaley
Copy link
Member

ldaley commented Mar 28, 2014

Changes went in here: f3edadb

Makes it possible to do parse(SomeType).

The documentation in the area of parsing and the Jackson stuff in general is pretty weak. Any help there at all would be very welcome :)

Don't forget to send a PR with yourself added to the contributors list at least.

@craigburke
Copy link
Contributor Author

Yeah, I saw that change, that's awesome! I can definitely take a stab at adding some documentation there. It's a good excuse to dig into that code a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants