Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Pac4JCallbackHandler with a builder #477

Merged
merged 1 commit into from
Oct 31, 2014
Merged

Build Pac4JCallbackHandler with a builder #477

merged 1 commit into from
Oct 31, 2014

Conversation

tomdcc
Copy link
Contributor

@tomdcc tomdcc commented Oct 30, 2014

Take 2, now with more builders.

Bikeshedding:

  • I left the default functions in the handler itself rather than putting them in the builder or separate classes.
  • There's still a no-arg constructor to get the current behaviour.

@robzienert
Copy link
Contributor

This will definitely be helpful for our app.

ldaley added a commit that referenced this pull request Oct 31, 2014
@ldaley
Merge pull request #477 from tomdcc/pac4j-callback-handler-builder
e16e884 
Build Pac4JCallbackHandler with a builder
@ldaley ldaley merged commit e16e884 into ratpack:master Oct 31, 2014
@ldaley ldaley added this to the release-0.9.10 milestone Oct 31, 2014
@ldaley ldaley self-assigned this Oct 31, 2014
@tomdcc
Copy link
Contributor Author

tomdcc commented Oct 31, 2014

Thanks!

@tomdcc tomdcc deleted the pac4j-callback-handler-builder branch October 31, 2014 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ldaley ldaley

Labels
None yet
Projects
None yet
Milestone
release-0.9.10
Development

Successfully merging this pull request may close these issues.
3 participants
@tomdcc @robzienert @ldaley