Copy response buffer in BlockingHttpClient onto heap instead of leaking the non-heap one #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the non-heap one. Closes #875.
|
Are you sure that this is necessary, given that the buffer being copied is unpooled? |
|
Ah I see, it's still using a direct buffer. I hadn't consider this. Will need to check for other similar usages. |
|
Going to merge and tweak slightly. |
ldaley
added a commit
that referenced
this pull request
Jan 11, 2016
Copy response buffer in BlockingHttpClient onto heap instead of leaking the non-heap one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #875.