Sic bugfixes #10
Merged
Sic bugfixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some values are only taken once during the hour and thus have a cnt=1 and rawdata=NA. The actual data is stored in Val, which otherwise holds the average. Since after expansion, rawdata is the main data field, the value from Val needs to be moved to rawdata in this case.
- Fix sic bugs - Slack temp range
|
@mlondschien this is ready for you to have a look at. I checked densities of most variables against MIMIC and HiRID and it looks good now. |
mlondschien
reviewed
Mar 26, 2024
R/callback-itm.R
Outdated
| @@ -213,6 +213,16 @@ mimic_age <- function(x) { | |||
|
|
|||
| eicu_age <- function(x) as.numeric(ifelse(x == "> 89", 90, x)) | |||
|
|
|||
| sic_sex <- function(x) { | |||
There was a problem hiding this comment.
How is this different from apply_map(735="Female", 735="Male"))?
There was a problem hiding this comment.
Jup, definitely the same and simpler. That came from merging PR code from eth-mds. Fixed it.
|
@mlondschien if you approve, please merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.