Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noxcal #470

Merged
merged 28 commits into from
Apr 13, 2023
Merged

Noxcal #470

merged 28 commits into from
Apr 13, 2023

Conversation

JSKenyon
Copy link
Collaborator

@JSKenyon JSKenyon commented Apr 5, 2023

Opening this PR for visibility.

JSKenyon and others added 25 commits September 20, 2019 09:12
* partial fix for #93. Should allow for one spw at a time

* fixes #93. Adds workaround for casacore/python-casacore#130

* added future-fstrings

* correctly named future-fstrings

* ...and install it for all pythons

* back to mainstream sharedarray

* lowered message verbosity

* droppping support for python<3.6

* Issues 427 and 429 (#430)

* Fixes #427

* Fixes #429

* Update __init__.py

Bump version

* Update Jenkinsfile.sh (#447)

* Update Jenkinsfile.sh

Remove python 2 building

* Update Jenkinsfile.sh

* Issue 431 (#432)

* Beginning of nobeam functionality.

* Remove duplicated source provider.

* Change syntax for python 2.7 compatibility.

* Update montblanc version in setup to avoid installation woes.

Co-authored-by: JSKenyon <jonosken@gmail.com>

* Remove two uses of future_fstrings.

* make pypi compatible (#446)

* make pypi compatible

* error

* Update setup.py

Only support up to v0.6.1 of montblanc

* Update setup.py

Co-authored-by: Benjamin Hugo <bennahugo@gmail.com>
Co-authored-by: JSKenyon <jskenyon007@gmail.com>
Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com>

* Update __init__.py

* Fix warning formatting

Co-authored-by: Oleg Smirnov <osmirnov@gmail.com>
Co-authored-by: Benjamin Hugo <bennahugo@gmail.com>
Co-authored-by: JSKenyon <jskenyon007@gmail.com>
Co-authored-by: JSKenyon <jonosken@gmail.com>
Co-authored-by: Gijs Molenaar <gijs@pythonic.nl>
Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com>
@KshitijT
Copy link
Collaborator

KshitijT commented Apr 5, 2023

I confirm that it is very visible. :P

cubical/main.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@JSKenyon JSKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I authored the PR, I am not allowed to approve the changes. @o-smirnov I have given this a once over. Nothing looks too terrifying but it is 1.5k lines of code so I may have missed something.

@JSKenyon
Copy link
Collaborator Author

Unless there is a major objection before tomorrow morning, I will hit merge. Thereafter, I will delete this branch and urge super-users to abuse master for a while before we do another release.

@JSKenyon JSKenyon merged commit ff219d0 into master Apr 13, 2023
@JSKenyon JSKenyon deleted the noxcal branch April 13, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants