Issue 431 #432
Merged
Issue 431 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
@o-smirnov this is ready for review. We can wait and see if things work out for @ulricharmel before merging though. |
Merged
|
@o-smirnov could you please review? |
o-smirnov
added a commit
that referenced
this pull request
May 12, 2021
* partial fix for #93. Should allow for one spw at a time * fixes #93. Adds workaround for casacore/python-casacore#130 * added future-fstrings * correctly named future-fstrings * ...and install it for all pythons * back to mainstream sharedarray * lowered message verbosity * droppping support for python<3.6 * Issues 427 and 429 (#430) * Fixes #427 * Fixes #429 * Update __init__.py Bump version * Update Jenkinsfile.sh (#447) * Update Jenkinsfile.sh Remove python 2 building * Update Jenkinsfile.sh * Issue 431 (#432) * Beginning of nobeam functionality. * Remove duplicated source provider. * Change syntax for python 2.7 compatibility. * Update montblanc version in setup to avoid installation woes. Co-authored-by: JSKenyon <jonosken@gmail.com> * Remove two uses of future_fstrings. * make pypi compatible (#446) * make pypi compatible * error * Update setup.py Only support up to v0.6.1 of montblanc * Update setup.py Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> * Update __init__.py * Fix warning formatting Co-authored-by: Oleg Smirnov <osmirnov@gmail.com> Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonosken@gmail.com> Co-authored-by: Gijs Molenaar <gijs@pythonic.nl> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com>
JSKenyon
added a commit
that referenced
this pull request
Apr 13, 2023
* Added different slope modes for slope solvers. Experimental. * initial rehashing to support a more geneal slope structure (e.g. iono+delay) * fixes #428 * fixes #433 * no-X polcal experiments * added support for arbitrary Jones terms in *first* chain position * fixed typo * Noxcal (#450) * partial fix for #93. Should allow for one spw at a time * fixes #93. Adds workaround for casacore/python-casacore#130 * added future-fstrings * correctly named future-fstrings * ...and install it for all pythons * back to mainstream sharedarray * lowered message verbosity * droppping support for python<3.6 * Issues 427 and 429 (#430) * Fixes #427 * Fixes #429 * Update __init__.py Bump version * Update Jenkinsfile.sh (#447) * Update Jenkinsfile.sh Remove python 2 building * Update Jenkinsfile.sh * Issue 431 (#432) * Beginning of nobeam functionality. * Remove duplicated source provider. * Change syntax for python 2.7 compatibility. * Update montblanc version in setup to avoid installation woes. Co-authored-by: JSKenyon <jonosken@gmail.com> * Remove two uses of future_fstrings. * make pypi compatible (#446) * make pypi compatible * error * Update setup.py Only support up to v0.6.1 of montblanc * Update setup.py Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> * Update __init__.py * Fix warning formatting Co-authored-by: Oleg Smirnov <osmirnov@gmail.com> Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonosken@gmail.com> Co-authored-by: Gijs Molenaar <gijs@pythonic.nl> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> * fixed bug when outer chain term was DD and incorrect model was used. Properly implemented scalar updates * added scalar and unislope update types * added auto-generated Stimela2 schemas * added schemas to manifest * use / separator for stimela schema; omit defaults in schema; fix path * minor bugfixes * added stimela_cabs file. Fixed problem with legacy-only flags on output * added stimela_cabs.yml * changed / to . * fixed problem with IFR gain flags overpropagating * added parset argument --------- Co-authored-by: Oleg Smirnov <osmirnov@gmail.com> Co-authored-by: Lexy Andati <andatilexy@gmail.com> Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: Gijs Molenaar <gijs@pythonic.nl>
o-smirnov
added a commit
that referenced
this pull request
Feb 12, 2024
* Added different slope modes for slope solvers. Experimental. * initial rehashing to support a more geneal slope structure (e.g. iono+delay) * fixes #428 * fixes #433 * no-X polcal experiments * added support for arbitrary Jones terms in *first* chain position * fixed typo * Noxcal (#450) * partial fix for #93. Should allow for one spw at a time * fixes #93. Adds workaround for casacore/python-casacore#130 * added future-fstrings * correctly named future-fstrings * ...and install it for all pythons * back to mainstream sharedarray * lowered message verbosity * droppping support for python<3.6 * Issues 427 and 429 (#430) * Fixes #427 * Fixes #429 * Update __init__.py Bump version * Update Jenkinsfile.sh (#447) * Update Jenkinsfile.sh Remove python 2 building * Update Jenkinsfile.sh * Issue 431 (#432) * Beginning of nobeam functionality. * Remove duplicated source provider. * Change syntax for python 2.7 compatibility. * Update montblanc version in setup to avoid installation woes. Co-authored-by: JSKenyon <jonosken@gmail.com> * Remove two uses of future_fstrings. * make pypi compatible (#446) * make pypi compatible * error * Update setup.py Only support up to v0.6.1 of montblanc * Update setup.py Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> * Update __init__.py * Fix warning formatting Co-authored-by: Oleg Smirnov <osmirnov@gmail.com> Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: JSKenyon <jonosken@gmail.com> Co-authored-by: Gijs Molenaar <gijs@pythonic.nl> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> * fixed bug when outer chain term was DD and incorrect model was used. Properly implemented scalar updates * added scalar and unislope update types * added auto-generated Stimela2 schemas * added schemas to manifest * use / separator for stimela schema; omit defaults in schema; fix path * minor bugfixes * added stimela_cabs file. Fixed problem with legacy-only flags on output * added stimela_cabs.yml * changed / to . * fixed problem with IFR gain flags overpropagating * Update __init__.py * Stimelation (#480) * fixes to AIPS leakage plotter (more table format support); started an AIPS bandpass plotter but this is WIP * add check for INDE value in PRTAB leakages * changed to hierarchical config --------- Co-authored-by: JSKenyon <jskenyon007@gmail.com> Co-authored-by: Jonathan <jonosken@gmail.com> Co-authored-by: Lexy Andati <andatilexy@gmail.com> Co-authored-by: Benjamin Hugo <bennahugo@gmail.com> Co-authored-by: Gijs Molenaar <gijs@pythonic.nl> Co-authored-by: JSKenyon <jonathan.simon.kenyon@gmail.com> Co-authored-by: Athanaseus Javas Ramaila <aramaila@ska.ac.za>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the predict honour nobeam tags in the lsm. Note that this is always on - if you have nobeam sources, make sure they retain their apparent flux values in the model. My own tests suggest that this works correctly, but please raise issues If there is a major performance degradation or something I missed.