Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dbus dependency #506

Closed
jluebbe opened this issue Nov 6, 2019 · 3 comments
Closed

Avoid dbus dependency #506

jluebbe opened this issue Nov 6, 2019 · 3 comments
Assignees
Labels
enhancement Adds new functionality or enhanced handling to RAUC
Milestone

Comments

@jluebbe
Copy link
Member

jluebbe commented Nov 6, 2019

Since 7698cad we have a strict dependency on the dbus-1 pkg-config module. @michaelolbrich suggested to only search for it if --with-dbussystemservicedir=DIR is not given on the configure command-line and we actually need to do the auto-configuration. When this is fixed, the workaround in meta-rauc should be removed (see rauc/meta-rauc#92).

@jluebbe jluebbe added the enhancement Adds new functionality or enhanced handling to RAUC label Nov 6, 2019
@jluebbe jluebbe added this to the Release v1.3 milestone Nov 6, 2019
@jluebbe
Copy link
Member Author

jluebbe commented Mar 10, 2020

@michaelolbrich In jluebbe@d1e0914, I tried to implement this. Is seems to work (no checking for DBUS1... yes when the -with-*=DIR options are given), but if they are not, it searches for DBUS1 three times. Is there a better way?

@ejoerns ejoerns modified the milestones: Release v1.3, Release v1.4 Mar 10, 2020
ukleinek added a commit to ukleinek/rauc that referenced this issue Mar 10, 2020
…ectory

The dbus-1 pkgfile is only used if at least one of the three parameters

  --with-dbuspolicydir
  --with-dbussystemservicedir
  --with-dbusinterfacesdir

isn't specified. So only check for dbus-1 in this case which allows to
weaken build dependencies in some circumstances.

Closes: rauc#506
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
ukleinek added a commit to ukleinek/rauc that referenced this issue Mar 11, 2020
PKG_CHECK_VAR is clever enough to not require PKG_CHECK_MODULES
beforehand. Also it allows overwriting using variables, so the previous
options --with-dbus-policydir etc. can be dropped, use

	./configure DBUS_POLICYDIR=...

instead. (This also better matches the usual autoconf semantics where
--with-$something is to configure with an external software package, not
to configure a path.)

Another change is that failures to query a variable from pkg-config now
aborts configure.

Closes: rauc#506
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
@jluebbe jluebbe modified the milestones: Release v1.4, Release v1.5 Sep 4, 2020
@ejoerns ejoerns modified the milestones: Release v1.5, Release 1.6 Jan 4, 2021
@jluebbe
Copy link
Member Author

jluebbe commented Jan 26, 2022

Instead of solving these minor issues with our autotools setup, I'd prefer to close this and move to Meson (#829). @ejoerns, what do you think?

@ejoerns
Copy link
Member

ejoerns commented Jan 26, 2022

@jluebbe time is probably better invested in meson support as long as this does not cause any real-world pain (which it does not seem to).

I'll just close this as this was idle for quite a long time already, anyway.

@ejoerns ejoerns closed this as completed Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality or enhanced handling to RAUC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants