nbd.c: use off_t instead of off64_t with _FILE_OFFSET_BITS=64 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With _FILE_OFFSET_BITS=64 there is no "off64_t", but off_t is 64 bit long: https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fFILE_005fOFFSET_005fBITS While glibc defines the off64_t anyway, musl is more restrictive and only provides the "off64_t" when _LARGEFILE64_SOURCE is defined. Signed-off-by: Christian Hohnstaedt <christian@hohnstaedt.de>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 80.20% 80.20%
=======================================
Files 58 58
Lines 17997 17997
=======================================
Hits 14435 14435
Misses 3562 3562
☔ View full report in Codecov by Sentry. |
jluebbe
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With _FILE_OFFSET_BITS=64 there is no "off64_t", but off_t is 64 bit long: https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fFILE_005fOFFSET_005fBITS
While glibc defines the off64_t anyway, musl is more restrictive and only provides the "off64_t" when _LARGEFILE64_SOURCE is defined.
Signed-off-by: Christian Hohnstaedt christian@hohnstaedt.de