Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: clarify license #1211

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

rohieb
Copy link
Contributor

@rohieb rohieb commented Aug 8, 2023

Simply including the LGPL license text is not enough information to determine the license of a software project, as Section 13 of the LGPL allows licensees to choose the terms of "any later version of the license" if specified so by the copyright holders.

The information in meson.build implies "LGPL-2.1-or-later" as project license. As a minimal measure to make this information explicit, add the usual license notice and warranty disclaimer as recommended in the GNU GPL How-To (also see [https://www.gnu.org/licenses/identify-licenses-clearly.html]) to the README file, and also add a minimal copyright notice as required by Section 1 of the LGPL.

Let the LGPL badge at the start of the README point to the relevant section further down.

@rohieb
Copy link
Contributor Author

rohieb commented Aug 8, 2023

I stumbled on this issue because PTXdist specifies "LGPL-2.1-only" as software license in rules/rauc.make, which does not match the license in RAUC's meson.build or in meta-rauc.

@jluebbe jluebbe self-requested a review August 8, 2023 13:33
@jluebbe jluebbe added the documentation Patch targets fixing or extending documentation label Aug 8, 2023
jluebbe
jluebbe previously approved these changes Aug 8, 2023
@jluebbe jluebbe requested a review from ejoerns August 8, 2023 13:33
@jluebbe jluebbe added this to the Release v1.11 milestone Aug 8, 2023
README.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (c9a6f87) 80.16% compared to head (b200025) 80.29%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   80.16%   80.29%   +0.13%     
==========================================
  Files          58       61       +3     
  Lines       18176    18401     +225     
==========================================
+ Hits        14570    14775     +205     
- Misses       3606     3626      +20     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Simply including the LGPL license text is not enough information to
determine the license of a software project, as Section 13 of the LGPL
allows licensees to choose the terms of "any later version of the
license" if specified so by the copyright holders.

The information in meson.build implies "LGPL-2.1-or-later" as project
license. As a minimal measure to make this information explicit, add the
usual license notice and warranty disclaimer as recommended in the GNU
GPL How-To to the README file, and also add a minimal copyright notice
as required by Section 1 of the LGPL.

Let the LGPL badge at the start of the README point to the relevant
section further down.

Link: https://www.gnu.org/licenses/gpl-howto.html#why-license-notices
Link: https://www.gnu.org/licenses/identify-licenses-clearly.html
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
Copy link
Member

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now 👍

@rohieb Thanks for improving the licensing infos!

@ejoerns ejoerns merged commit 23710df into rauc:master Aug 8, 2023
24 checks passed
@rohieb rohieb deleted the license-clarification branch August 8, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Patch targets fixing or extending documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants