avoid possible OOB read in bootchooser backends #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using g_subprocess_communicate, we often need to process the stdout as a null-terminated string (instead of a GBytes). While there is g_subprocess_communicate_utf8, we can't be sure that the output is actually valid UTF-8, so we need our own helper. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
…f-bound reads For clarity, use the names variable names stdout_bytes and stdout_str consistently. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
ejoerns
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
g_subprocess_communicate, we often need to process the stdout as a null-terminated string (instead of aGBytes). While there isg_subprocess_communicate_utf8, we can't be sure that the output is actually valid UTF-8, so we need our own helper.While we've not seen any issues with this in CI or in the field, it's better do be careful.