Add new InstallBundle Method to D-Bus API #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoerns
force-pushed
the
topic/new-install-api
branch
2 times, most recently
from
ddc325c
to
9a2374d
Compare
ejoerns
force-pushed
the
topic/new-install-api
branch
from
9a2374d
to
a88cfd5
Compare
jluebbe
force-pushed
the
topic/new-install-api
branch
from
a88cfd5
to
5b2b745
Compare
|
I've pushed a rebase onto master. The the conflicts were caused by the network mode removal. |
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 66.50% 66.71% +0.20%
==========================================
Files 24 24
Lines 6553 6576 +23
==========================================
+ Hits 4358 4387 +29
+ Misses 2195 2189 -6
Continue to review full report at Codecov.
|
ejoerns
force-pushed
the
topic/new-install-api
branch
from
5b2b745
to
9166434
Compare
ejoerns
changed the title
|
We also have tests for this and it remained in RFC phase for some days. Thus we can remove the RFC label now and make it a normal PR ready for being reviewed and merged. |
ejoerns
force-pushed
the
topic/new-install-api
branch
from
9740c26
to
347a3c5
Compare
ejoerns
force-pushed
the
topic/new-install-api
branch
from
347a3c5
to
1ac76ef
Compare
michaelolbrich
suggested changes
Feb 10, 2020
ejoerns
force-pushed
the
topic/new-install-api
branch
3 times, most recently
from
96f4407
to
bd472f6
Compare
michaelolbrich
suggested changes
Feb 12, 2020
jluebbe
force-pushed
the
topic/new-install-api
branch
from
bd472f6
to
fd52ecb
Compare
jluebbe
requested changes
Apr 21, 2020
jluebbe
force-pushed
the
topic/new-install-api
branch
from
fd52ecb
to
48a9c7f
Compare
ejoerns
force-pushed
the
topic/new-install-api
branch
3 times, most recently
from
a0718fd
to
b2e55e9
Compare
Otherwise we may run out of space after several tests. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
This method aims to replace the former 'Install' method used to trigger bundle installations. The old method lacked the capability of passing additional arguments, which prevented from adding a lot of features in the past. Compared to the existing one, the new method differs only in the additional array-of-string-variant parameter 'args'. This allows to pass all kind of future additional simple arguments. To guarantee API stability, the old method will be kept as an alternative. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
…thod Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
While the new API method will be tested by the RAUC client implementation, anyway, we need to have an explicit test ensuring nothing of the deprecated API is broken accidentally. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Also mark it as failed when needed. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
We should not accept unknown keys to prevent from performing actions not actually intended by the client. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
On the client side, this will ease identifying what went wrong Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
We test that unknown arguments are rejected, we test that invalid keys are rejected, we test that having both valid key and value is accepted. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
jluebbe
force-pushed
the
topic/new-install-api
branch
from
b2e55e9
to
75a087a
Compare
jluebbe
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, there were a lot of cases where we ran into the limitation of the
Installmethod of the D-BusInstallerinterface. These were all caused by the missing ability to pass additional arguments to the install call.As we cannot break existing setups, we cannot simply change the method signature. Instead, we need to introduce an alternative method.
Here it is:
InstallBundle sa{sv}Where the new generic dict of string-variant (
a{sv}) allows passing and handling all kind of current and future parameters without changing the interface again.This initial series includes support for one argument that was already implemented for the non-D-Bus case:
--ignore-compatible. It allows forcing the installation of a bundle on a per-installation-call baseReference: #248