-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle: allow installing bundle from ZFS partitions #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/openzfs/zfs/blob/master/include/sys/fs/zfs.h#L1198 calls it LINUX_ZFS_SUPER_MAGIC. Please add it to the list in https://github.com/rauc/rauc/blob/master/src/bundle.c#L21-L81 with a comment where it was found.
Add `ZFS_SUPER_MAGIC` as defines in openzfs. Signed-off-by: Daniel Mack <daniel@zonque.org>
Ah, I missed that list. Thanks! Also, ZFS apparently cannot be checked with the rdev check in bundle.c so we have to set |
Updated. PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
=======================================
Coverage 72.81% 72.81%
=======================================
Files 28 28
Lines 8645 8645
=======================================
Hits 6295 6295
Misses 2350 2350
Continue to review full report at Codecov.
|
Yes, we're using it both on x86 and raspberrypis.
No, how would that help? |
With plain bundles, RAUC uses these checks to protect against the TOCTOU vulnerability: If it detects a verity bundle, these checks are not necessary and skipped. |
Add
ZFS_SUPER_MAGIC
as defines in openzfs.