-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RAUC_IMAGE_SIZE as hook variable #703
Conversation
2e397ba
to
a9df56a
Compare
This comment has been minimized.
This comment has been minimized.
What does a |
This comment has been minimized.
This comment has been minimized.
@hellow554 If I see it right, the context of the variable should be the function, thus this should be sufficient for setting the environment. Just to be sure that it is no autofree issue, just leave out the From a quick look into this, I don't have a clue what is going wrong, yet. The positive number from your first run is the correct size? |
This comment has been minimized.
This comment has been minimized.
Hmm, what is happening with these tests? The only one I can see so far failing is https://github.com/rauc/rauc/pull/703/checks?check_run_id=1910777178#step:7:502 but I don't know what that actually means |
@hellow554 This is a sporadic error we are aware of. Unrelated to your changes. Would you squash the two commits into one? There is no benefit in keeping them separate I guess. |
This variable can be used to get the size of the file specified in the manifest. Signed-off-by: Marcel Hellwig <github@cookiesoft.de>
4c3f1ad
to
27eff3c
Compare
Done. Thanks for your help here! |
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 72.82% 72.82% -0.01%
==========================================
Files 28 28
Lines 8710 8713 +3
==========================================
+ Hits 6343 6345 +2
- Misses 2367 2368 +1
Continue to review full report at Codecov.
|
hey @ejoerns is there something missing so this could be merged? |
ping @ejoerns |
@hellow554 sorry for letting you wait, was a bit busy the last days. Thx @jluebbe for reviewing and merging! |
Closes #700