Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RAUC_IMAGE_SIZE as hook variable #703

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

hellow554
Copy link
Contributor

Closes #700

src/update_handler.c Outdated Show resolved Hide resolved
@ejoerns ejoerns added the enhancement Adds new functionality or enhanced handling to RAUC label Feb 16, 2021
@hellow554

This comment has been minimized.

@ejoerns
Copy link
Member

ejoerns commented Feb 16, 2021

Any idea why?

What does a rauc info on the bundle show? Also negative numbers or a proper value?

@hellow554

This comment has been minimized.

@ejoerns
Copy link
Member

ejoerns commented Feb 16, 2021

@hellow554 If I see it right, the context of the variable should be the function, thus this should be sufficient for setting the environment. Just to be sure that it is no autofree issue, just leave out the g_autofree for testing.

From a quick look into this, I don't have a clue what is going wrong, yet. The positive number from your first run is the correct size?

@hellow554

This comment has been minimized.

@hellow554
Copy link
Contributor Author

Hmm, what is happening with these tests? The only one I can see so far failing is

https://github.com/rauc/rauc/pull/703/checks?check_run_id=1910777178#step:7:502

but I don't know what that actually means

@ejoerns
Copy link
Member

ejoerns commented Feb 16, 2021

@hellow554 This is a sporadic error we are aware of. Unrelated to your changes.

Would you squash the two commits into one? There is no benefit in keeping them separate I guess.

This variable can be used to get the size of the file specified in the
manifest.

Signed-off-by: Marcel Hellwig <github@cookiesoft.de>
@hellow554
Copy link
Contributor Author

hellow554 commented Feb 16, 2021

Done.
I like to keep commits seperated when discussing about them, so it's easier to track changes. But yes, before actually merging I like to squash them.

Thanks for your help here!

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #703 (4fdc2f2) into master (2182bcf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   72.82%   72.82%   -0.01%     
==========================================
  Files          28       28              
  Lines        8710     8713       +3     
==========================================
+ Hits         6343     6345       +2     
- Misses       2367     2368       +1     
Impacted Files Coverage Δ
src/update_handler.c 56.91% <100.00%> (+0.12%) ⬆️
src/main.c 76.14% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2182bcf...27eff3c. Read the comment docs.

@hellow554
Copy link
Contributor Author

hey @ejoerns is there something missing so this could be merged?

@hellow554
Copy link
Contributor Author

ping @ejoerns

@jluebbe jluebbe merged commit 50f5bd7 into rauc:master Mar 5, 2021
@ejoerns
Copy link
Member

ejoerns commented Mar 5, 2021

@hellow554 sorry for letting you wait, was a bit busy the last days. Thx @jluebbe for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality or enhanced handling to RAUC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing image information to run_slot_hook
3 participants