Fix configurable U-Boot attempt setting #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit ebbdb4b ("Make U-Boot attempt settings configurable") made it possible to tweak the number of attempts that are set in the U-Boot environment. There is an issue with that because U-Boot's setexpr can only handle hex, while in the current implementation those values are treated as decimals. To work around that, let's treat those numbers as hex everywhere. Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
pascalhuerst
force-pushed
the
fix_hex_vs_dec
branch
from
abf8db8
to
d440229
Compare
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 28 28
Lines 8713 8713
=======================================
Hits 6346 6346
Misses 2367 2367
Continue to review full report at Codecov.
|
ejoerns
approved these changes
Mar 25, 2021
Yes we were :) |
jluebbe
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ebbdb4b ("Make U-Boot attempt settings configurable") made
it possible to tweak the number of attempts that are set in the U-Boot
environment.
There is an issue with that because U-Boot's setexpr can only handle
hex, while in the current implementation those values are treated as
decimals.
To work around that, let's treat those numbers as hex everywhere.