Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated Install with InstallBundle method #744

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

rforro
Copy link
Contributor

@rforro rforro commented Jun 17, 2021

According to this the used Install method in cgi.c has been deprecated. Therefor it was replaced by InstallBundle. Currently no arguments are passed to installation. If you have an idea how to pass them (custom header? query param?) I can integrate it as well.

Signed-off-by: Richard Forro <riki49@gmail.com>
@Bastian-Krause
Copy link
Member

Thanks for the PR!

Could you update the link to the install method in contrib/cgi/README.rst accordingly?
I think it's not a good idea to allow passing options such as ignore-compatible via HTTP.

Signed-off-by: Richard Forro <riki49@gmail.com>
@rforro
Copy link
Contributor Author

rforro commented Jun 17, 2021

README is updated!

OK, I don't use the ignore-compatible parameter anyway.

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #744 (22b6f1a) into master (a070527) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          28       28           
  Lines        8715     8715           
=======================================
  Hits         6361     6361           
  Misses       2354     2354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a070527...22b6f1a. Read the comment docs.

@jluebbe jluebbe merged commit 183f67b into rauc:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants