Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing XML definition of arguments direction for Install and InstallBundle methods #786

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

zaporozhets
Copy link
Contributor

Added missing definition of direction for source argument in Install and InstallBundle dbus methods. It helps sdbus-c++ to generate correct stubs. For example:

Before:

    void Install()
    {
        proxy_.callMethod("Install").onInterface(INTERFACE_NAME);
    }

    void InstallBundle(const std::map<std::string, sdbus::Variant>& args)
    {
        proxy_.callMethod("InstallBundle").onInterface(INTERFACE_NAME).withArguments(args);
    }

After:

    void Install(const std::string& source)
    {
        proxy_.callMethod("Install").onInterface(INTERFACE_NAME).withArguments(source);
    }

    void InstallBundle(const std::string& source, const std::map<std::string, sdbus::Variant>& args)
    {
        proxy_.callMethod("InstallBundle").onInterface(INTERFACE_NAME).withArguments(source, args);
    }

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #786 (6e5c832) into master (1564c3a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   72.85%   72.84%   -0.02%     
==========================================
  Files          28       28              
  Lines        8798     8798              
==========================================
- Hits         6410     6409       -1     
- Misses       2388     2389       +1     
Impacted Files Coverage Δ
src/main.c 75.41% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1564c3a...6e5c832. Read the comment docs.

…for 'source' argument

This adds missing definition of direction for 'source' argument in
'Install' and 'InstallBundle' D-Bus methods.

Signed-off-by: Taras Zaporozhets <zaporozhets.taras@gmail.com>
Copy link
Member

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've slightly adapted the commit message's title to better match our conventions.

Otherwise, looks fine for me. Good catch and thanks for your Contribution! 👍

Note: Accept despite CI fails (unrelated known issue).

@jluebbe jluebbe added the fixed label Oct 25, 2021
@jluebbe jluebbe merged commit b963212 into rauc:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants