Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dm-crypt section to faq documentation page #835

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Add dm-crypt section to faq documentation page #835

merged 1 commit into from
Feb 1, 2022

Conversation

fabianbuettner
Copy link
Contributor

Closes #830
Signed-off-by: Fabian Büttner fabian.buettner@rub.de

@ejoerns
Copy link
Member

ejoerns commented Jan 31, 2022

Thanks for the patch!

Please let the Mail used for Signed-off-by match your git commit author mail (see DCO check failure)

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #835 (c6a61fc) into master (1289add) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   72.72%   72.73%   +0.01%     
==========================================
  Files          28       28              
  Lines        9089     9089              
==========================================
+ Hits         6610     6611       +1     
+ Misses       2479     2478       -1     
Impacted Files Coverage Δ
src/main.c 76.25% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1289add...c6a61fc. Read the comment docs.

@fabianbuettner
Copy link
Contributor Author

Sorry, I forgott to change the author's email address to use the correct email address. This is my first PR :) what's the right way to fix this?

@ejoerns
Copy link
Member

ejoerns commented Jan 31, 2022

@fabianbuettner no worries ;) You can just fix you commit and force-push on the branch you created this PR from

@jluebbe jluebbe added this to the Release v1.6 milestone Feb 1, 2022
Signed-off-by: Fabian Büttner <fabian.buettner@rub.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an example config snippet and made some minor wording changes.

Thanks for your contribution!

@ejoerns ejoerns merged commit 52ce3bd into rauc:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAUC and plain dm-crypt volumes as rootfs slots
3 participants