src/bootchooser: fix pair of memory leaks #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyga
force-pushed
the
fix/missing-free
branch
from
e9368a9
to
971d19f
Compare
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 69.58% 69.58%
=======================================
Files 30 30
Lines 10070 10072 +2
=======================================
+ Hits 7007 7009 +2
Misses 3063 3063
Continue to review full report at Codecov.
|
While trying to understand the exact implementation of bootchooser_order_primary, I've noticed that the list is never freed. Jan Lübbe further noticed similar situation in barebox_set_primary. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com>
jluebbe
force-pushed
the
fix/missing-free
branch
from
971d19f
to
f64441a
Compare
jluebbe
changed the title
jluebbe
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a drive-by fix, while trying to understand the exact
implementation of bootchooser_order_primay I've noticed that the list is
never freed. Jan Luebbe further noticed similar situation in
barebox_set_primary
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@huawei.com