Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/signature: get key passphrase from environment #945

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

marckleinebudde
Copy link
Contributor

@marckleinebudde marckleinebudde commented Aug 15, 2022

The user can add the passphrase of the private key to the environment
variable RAUC_KEY_PASSPHRASE. Pass this to PEM_read_bio_PrivateKey()
if set.

Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de

@marckleinebudde marckleinebudde force-pushed the key-passphrase branch 3 times, most recently from 10c4a11 to 24921a6 Compare August 16, 2022 10:08
Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a test case as well.

docs/advanced.rst Outdated Show resolved Hide resolved
docs/advanced.rst Outdated Show resolved Hide resolved
docs/reference.rst Outdated Show resolved Hide resolved
rauc.1 Outdated Show resolved Hide resolved
src/signature.c Outdated Show resolved Hide resolved
@marckleinebudde marckleinebudde force-pushed the key-passphrase branch 4 times, most recently from ea4912e to a912f86 Compare August 16, 2022 10:50
docs/advanced.rst Outdated Show resolved Hide resolved
docs/advanced.rst Outdated Show resolved Hide resolved
docs/advanced.rst Outdated Show resolved Hide resolved
The user can add the passphrase of the private key to the environment
variable RAUC_KEY_PASSPHRASE. Pass this to PEM_read_bio_PrivateKey()
if set.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
@ejoerns ejoerns added the enhancement Adds new functionality or enhanced handling to RAUC label Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #945 (f2710ef) into master (5538d20) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   69.81%   69.81%   -0.01%     
==========================================
  Files          31       31              
  Lines       11060    11063       +3     
==========================================
+ Hits         7722     7724       +2     
- Misses       3338     3339       +1     
Impacted Files Coverage Δ
src/signature.c 79.66% <75.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jluebbe jluebbe merged commit 351eea8 into rauc:master Aug 16, 2022
@jluebbe
Copy link
Member

jluebbe commented Aug 16, 2022

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality or enhanced handling to RAUC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants