Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/utils.c: fix null reference error for g_propagate_prefixed_error #999

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

jungte
Copy link
Contributor

@jungte jungte commented Oct 27, 2022

It's my first PR. Please let me know if I did something wrong.

@ejoerns
Copy link
Member

ejoerns commented Oct 27, 2022

@jungte Thanks for the fix! Looks fine at first sight.

Please add your Signed-off-by line to the patch (git commit --amend -s):

https://rauc.readthedocs.io/en/latest/contributing.html#developer-s-certificate-of-origin

You can simply force-push your branch to update the PR then.

@ejoerns
Copy link
Member

ejoerns commented Oct 27, 2022

The DCO check is not fully happy yet, since the mails do not match:

https://github.com/rauc/rauc/pull/999/checks?check_run_id=9133823272

Oh, still 1 PR to go...

@jungte
Copy link
Contributor Author

jungte commented Oct 27, 2022

Oh, I saw the problem..
I will submit a new PR again, Let's close this PR first.

@jungte jungte closed this Oct 27, 2022
@jluebbe
Copy link
Member

jluebbe commented Oct 27, 2022

You don't need to close the PR, you can just force-push to replace the commit.

@jungte
Copy link
Contributor Author

jungte commented Oct 27, 2022

OK, will try to do it later.

@jluebbe jluebbe reopened this Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 71.16% // Head: 71.14% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (89278fa) compared to base (ab94e69).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 89278fa differs from pull request most recent head 0cbc75c. Consider uploading reports for the commit 0cbc75c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   71.16%   71.14%   -0.02%     
==========================================
  Files          34       34              
  Lines       11579    11582       +3     
==========================================
  Hits         8240     8240              
- Misses       3339     3342       +3     
Impacted Files Coverage Δ
src/utils.c 73.00% <0.00%> (-0.56%) ⬇️
src/nbd.c 35.10% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/utils.c Outdated Show resolved Hide resolved
src/utils.c Outdated Show resolved Hide resolved
src/utils.c Outdated Show resolved Hide resolved
src/utils.c Outdated Show resolved Hide resolved
@ejoerns ejoerns added this to the Release v1.9 milestone Nov 9, 2022
@ejoerns
Copy link
Member

ejoerns commented Nov 25, 2022

@jungte would you like to incorporate the requested changes so we can merge this? Or should we?

@jungte
Copy link
Contributor Author

jungte commented Nov 28, 2022

@ejoerns Sure, I can do it in next few days if you can wait. The holiday is getting over.. :)

@ejoerns
Copy link
Member

ejoerns commented Nov 28, 2022

@jungte next few days will be sufficient. Just wanted to make sure that someone cares about it ;) Enjoy the rest of your holiday!

Signed-off-by: Kevin Hsieh <jthsieh@gmail.com>
@ejoerns
Copy link
Member

ejoerns commented Dec 21, 2022

I've updated the branch to resolve a code style issue reported by uncrustify

@jluebbe jluebbe merged commit dc7216a into rauc:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants