-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/utils.c: fix null reference error for g_propagate_prefixed_error #999
Conversation
@jungte Thanks for the fix! Looks fine at first sight. Please add your https://rauc.readthedocs.io/en/latest/contributing.html#developer-s-certificate-of-origin You can simply force-push your branch to update the PR then. |
The DCO check is not fully happy yet, since the mails do not match: https://github.com/rauc/rauc/pull/999/checks?check_run_id=9133823272 Oh, still 1 PR to go... |
Oh, I saw the problem.. |
You don't need to close the PR, you can just force-push to replace the commit. |
OK, will try to do it later. |
Codecov ReportBase: 71.16% // Head: 71.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 71.16% 71.14% -0.02%
==========================================
Files 34 34
Lines 11579 11582 +3
==========================================
Hits 8240 8240
- Misses 3339 3342 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@jungte would you like to incorporate the requested changes so we can merge this? Or should we? |
@ejoerns Sure, I can do it in next few days if you can wait. The holiday is getting over.. :) |
@jungte next few days will be sufficient. Just wanted to make sure that someone cares about it ;) Enjoy the rest of your holiday! |
1aa678e
to
89278fa
Compare
Signed-off-by: Kevin Hsieh <jthsieh@gmail.com>
I've updated the branch to resolve a code style issue reported by uncrustify |
It's my first PR. Please let me know if I did something wrong.