feat: add component name to overlay #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunofreiberg
commented
Apr 30, 2020
| const [component] = Object.keys(node) | ||
| .filter(key => key.startsWith('__reactInternalInstance$')) | ||
| .map((key: string) => { | ||
| const fiberNode = (node as any)[key]; |
There was a problem hiding this comment.
I can't figure the types out here so I just told TS to shut up, for now.
There was a problem hiding this comment.
Don't be afraid to tell TS to shut it's annoying whining from time to time!
There was a problem hiding this comment.
How else would you expect it to learn some manners 馃槃
raunofreiberg
force-pushed
the
feat/component-trace
branch
from
1a2df62
to
ef61b4f
Compare
raunofreiberg
force-pushed
the
feat/component-trace
branch
from
ef61b4f
to
e8ce710
Compare
|
Looks good to me! |
chaance
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the ball rolling on #4.
Also, modified colors a bit to match the current theme 馃拝